-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigtable: Update user-agent to the latest version #3429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@igorbernstein2 @tbpg is there any reason we can't either 1. Use
const Repo = "20201104" |
It's easy to forget to update this value as is (as evidenced by the fact that it hasn't been updated in 2.5 years).
@mohanli-ml Won't direct path be denied in older version automatically since the new option is not being sent, why is extra header validation needed? Also, like you mention in #3330 ideally this would be semver. If we switch this header to be semver you would no longer be able to parse a date for this feature. |
@codyoss Yes, older versions before directpath release will not support directpath. However, we need this user agent for future. For example, we might have 3 versions that can support DP, and we realize one version has some problem, so we want to deny that one, but leave the other two still use DP. For semver, both semver and date can work, as long as the user agent is compatible with the library version. Since this is a blocker for me, may I ask do you have an ETA for this? How about I change the user agent to semver, so that you can approve it? Thanks! |
5aa4daa
to
cf260b6
Compare
@tritone Is this still waiting on anything? My comments were just that and don't want to hold anything up here. |
I'm fine with the switch to use the semver here. @igorbernstein2 @kolea2 can you confirm that this won't cause any backend or data collection issues that you know of? |
Currently the user agent of Bigtable in Go is standalone, as in https://github.com/googleapis/google-cloud-go/blob/master/bigtable/doc.go#L121m. Update it to the latest version https://pkg.go.dev/cloud.google.com/go/bigtable. Related issue: #3330.
Background: DirectPath will use user agent to deny a specific library version, so we want to update the user agent with the library release date.