Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub/pstest): make Message.Modacks thread safe #2755

Merged
merged 8 commits into from
Aug 21, 2020
Merged

fix(pubsub/pstest): make Message.Modacks thread safe #2755

merged 8 commits into from
Aug 21, 2020

Conversation

hongalex
Copy link
Member

Fixes #2754

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2020
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@hongalex hongalex requested review from tbpg and codyoss August 20, 2020 02:50
tbpg
tbpg suggested changes Aug 20, 2020
View reviewed changes
pubsub/pstest/fake.go Outdated Show resolved Hide resolved
pubsub/pstest/fake.go Outdated Show resolved Hide resolved
pubsub/pstest/fake_test.go Outdated Show resolved Hide resolved
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@hongalex hongalex requested a review from tbpg August 20, 2020 22:33
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 21, 2020
tbpg
tbpg approved these changes Aug 21, 2020
View reviewed changes
pubsub/pstest/fake_test.go Outdated Show resolved Hide resolved
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 21, 2020
@hongalex hongalex merged commit 5d56e13 into googleapis:master Aug 21, 2020
@hongalex hongalex deleted the pstest-modack branch August 21, 2020 22:50
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
@hongalex @tritone
fix(pubsub/pstest): make Message.Modacks thread safe (googleapis#2755)
9a2e713 
* fix(pubsub/pstest): make Message.Modacks thread safe

* restore original modack test

* address review comments

* replace todo contexts

* use t.Logf instead of fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

@codyoss codyoss Awaiting requested review from codyoss

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: pstest.Message.Modacks not thread safe
3 participants
@hongalex @tbpg @kokoro-team