Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Pass reverse flag from proxy to library #11395

Merged
merged 2 commits into from
Jan 8, 2025
Merged

test(bigtable): Pass reverse flag from proxy to library #11395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b2da24
test(bigtable): Pass reverse flag from proxy to library
bhshkh Jan 8, 2025
aefbcec
Merge branch 'main' into test/cbt-LastScannedRow-Reverse
bhshkh Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bigtable/internal/testproxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,12 @@ func (s *goTestProxyServer) ReadRows(ctx context.Context, req *pb.ReadRowsReques
var c int32
var rowsPb []*btpb.Row
lim := req.GetCancelAfterRows()

reversed := req.GetRequest().GetReversed()
opts := []bigtable.ReadOption{}
if reversed {
opts = append(opts, bigtable.ReverseScan())
}
err = t.ReadRows(ctx, rs, func(r bigtable.Row) bool {

c++
Expand All @@ -585,7 +591,7 @@ func (s *goTestProxyServer) ReadRows(ctx context.Context, req *pb.ReadRowsReques
}
rowsPb = append(rowsPb, rpb)
return true
})
}, opts...)

res := &pb.RowsResult{
Status: &statpb.Status{
Expand Down
Loading