-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): move start span logic for publish batch #11193
fix(pubsub): move start span logic for publish batch #11193
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
c692d21
to
2c8d48c
Compare
Fix: #11186
Having this span started while tracing is disabled do not directly cause memory leak, but if otel sdk is used together with other sdk such as sentry (which internally store a global map of otel span ID -> sentry span ID), if the span never ends the entries in this map is never GCed, and thus all the span object that they refers to never get GCed