Skip to content

Commit

Permalink
docs: add policy on new dependencies to contrib (#9341)
Browse files Browse the repository at this point in the history
Fixes #9340
  • Loading branch information
noahdietz authored Jan 30, 2024
1 parent 115646c commit 7b32627
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@

Commits will be squashed when they're merged.

## Policy on new dependencies

While the Go ecosystem is rich with useful modules, in this project we try to
minimize the number of direct dependencies we have on modules that are not
Google-owned.

Adding new third party dependencies can have the following effects:
* broadens the vulnerability surface
* increases so called "vanity" import routing infrastructure failure points
* increases complexity of our own [`third_party`][] imports

So if you are contributing, please either contribute the full implementation
directly, or find a Google-owned project that provides the functionality. Of
course, there may be exceptions to this rule, but those should be well defined
and agreed upon by the maintainers ahead of time.

## Testing

We test code against two versions of Go, the minimum and maximum versions
Expand Down Expand Up @@ -343,3 +359,4 @@ available at [https://contributor-covenant.org/version/1/2/0/](https://contribut
[gcloudcli]: https://developers.google.com/cloud/sdk/gcloud/
[indvcla]: https://developers.google.com/open-source/cla/individual
[corpcla]: https://developers.google.com/open-source/cla/corporate
[`third_party`]: https://opensource.google/documentation/reference/thirdparty

0 comments on commit 7b32627

Please sign in to comment.