feat: add mock library w/ StreamRange #9998

dbolduc · 2022-10-07T17:04:04Z

Fixes #9052

as discussed in go/cloud-cxx:mock-stream-range

This change is

google-cloud-cpp-bot · 2022-10-07T17:12:44Z

Google Cloud Build Logs
For commit: 94f9d00bae73a3593e31122265f35da440b0c850

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

codecov · 2022-10-07T17:16:54Z

Codecov Report

Base: 93.96% // Head: 93.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (111bea4) compared to base (e4ade72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9998   +/-   ##
=======================================
  Coverage   93.96%   93.97%           
=======================================
  Files        1513     1515    +2     
  Lines      139964   140003   +39     
=======================================
+ Hits       131524   131563   +39     
  Misses       8440     8440

Impacted Files	Coverage Δ
google/cloud/mocks/mock_stream_range.h	`100.00% <100.00%> (ø)`
google/cloud/mocks/mock_stream_range_test.cc	`100.00% <100.00%> (ø)`
...integration_tests/schema_admin_integration_test.cc	`98.88% <0.00%> (-1.12%)`	⬇️
google/cloud/pubsub/subscriber_connection_test.cc	`97.81% <0.00%> (-0.55%)`	⬇️
google/cloud/pubsub/samples/samples.cc	`90.70% <0.00%> (-0.15%)`	⬇️
google/cloud/storage/parallel_upload.cc	`98.62% <0.00%> (+0.34%)`	⬆️
...le/cloud/internal/default_completion_queue_impl.cc	`97.15% <0.00%> (+0.56%)`	⬆️
...ud/spanner/integration_tests/client_stress_test.cc	`84.86% <0.00%> (+0.65%)`	⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc	`100.00% <0.00%> (+2.94%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

google/cloud/google_cloud_cpp_common.cmake

coryan · 2022-10-07T19:22:36Z

google/cloud/google_cloud_cpp_common.cmake

+
+create_bazel_config(google_cloud_cpp_mocks YEAR "2022")
+
+google_cloud_cpp_install_headers("google_cloud_cpp_mocks"


FYI, I think this will install the .h file, but we are not installing the targets (see #5782). Can you check that the header installs correctly (maybe look at the installed files in one of the demo-* builds?)

I run

ci/cloudbuild.sh -t demo-fedora-pr -s # (inside docker shell now) ci/cloudbuild.sh --local --build demo-install # (build runs) ls /h/google-cloud-cpp-installed/include/google/cloud/mocks/ # Output: # mock_stream_range.h

And if I run:

grep -rl mocks /h/google-cloud-cpp-installed/lib64/cmake/ # Output: # /h/google-cloud-cpp-installed/lib64/cmake/google_cloud_cpp_pubsub/pubsub-targets.cmake

I take it that #5782 involves getting the other mock libraries to show up.

Maybe done? But does it need a pkgconfig thing like we do with rest_internal?

Should it have its own target separate from google_cloud_cpp_common-targets ?

Let's call it done. The pkgconfig thing will be needed for #5782

pkg-config has been left for a follow up PR.

I did move the targets out of google_cloud_cpp_common-targets.cmake and into a new google_cloud_cpp_mocks-targets.cmake. I think we want to do this to avoid installing the mock targets into the google_cloud_cpp_runtime component.

PTAL, because your original review was from a lifetime ago

There is no .pc file, but there is no -config.cmake file either. Is that intentional?

google-cloud-cpp-bot · 2022-10-08T06:34:52Z

Google Cloud Build Logs
For commit: 790755488e190dfa0fbb68b30e5b009220e7a8c2

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2022-10-08T06:38:16Z

Google Cloud Build Logs
For commit: 1c0faad2b35a170e5e6784b42a2113f1acb45d3c

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2022-10-08T07:02:03Z

Google Cloud Build Logs
For commit: dfdff86734fc5473ec2a2f5b13788fc871b7cb27

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww · 2022-10-10T17:49:46Z

google/cloud/BUILD.bazel

+load(":google_cloud_cpp_mocks.bzl", "google_cloud_cpp_mocks_hdrs")
+
+cc_library(
+    name = "google_cloud_cpp_mocks",


testonly?

google-cloud-cpp-bot · 2022-10-28T01:59:26Z

Google Cloud Build Logs
For commit: b722d1aee2e4e089864515356c0b73712d696607

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc

@dbolduc says the reviews are too old.

google-cloud-cpp-bot · 2022-10-28T02:15:42Z

Google Cloud Build Logs
For commit: 30a84cca360a2df040aa6bf6dc2e85632442b120

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

coryan · 2022-10-28T02:15:32Z

google/cloud/google_cloud_cpp_common.cmake

@@ -214,6 +214,42 @@ install(
    DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/google_cloud_cpp_common"
    COMPONENT google_cloud_cpp_development)

+# Create a header-only library for the mocks. We use a CMake `INTERFACE` library
+# for these, a regular library would not work on macOS (where the library needs
+# at least one .o file). Unfortunately INTERFACE libraries are a bit weird in


I think this comment is now out of date?

At the moment, it is a header only library.

yes, but you are not using the absolute paths anymore?

ah, thanks. I did not read the comment closely.

coryan · 2022-10-28T02:18:50Z

google/cloud/google_cloud_cpp_common.cmake

+
+create_bazel_config(google_cloud_cpp_mocks YEAR "2022")
+
+google_cloud_cpp_install_headers("google_cloud_cpp_mocks"


There is no .pc file, but there is no -config.cmake file either. Is that intentional?

coryan

Are you planning to add a test to cmake-install for this library?

google-cloud-cpp-bot · 2022-10-28T04:19:01Z

Google Cloud Build Logs
For commit: 111bea4635cdeb7693bf01f25ac482c3982c8524

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc · 2022-10-28T04:27:41Z

There is no .pc file, but there is no -config.cmake file either. Is that intentional?

Are you planning to add a test to cmake-install for this library?

I decided to just do the pkgconfig stuff in this PR. (and test it in an environment where find_dependency(GTest) finds gmock_main.)

dbolduc marked this pull request as ready for review October 7, 2022 18:03

dbolduc requested a review from a team as a code owner October 7, 2022 18:03

coryan approved these changes Oct 7, 2022

View reviewed changes

dbolduc force-pushed the feat-mocks-library branch from 7907554 to 1c0faad Compare October 8, 2022 06:36

dbolduc force-pushed the feat-mocks-library branch from 1c0faad to dfdff86 Compare October 8, 2022 07:00

coryan previously approved these changes Oct 9, 2022

View reviewed changes

devbww reviewed Oct 10, 2022

View reviewed changes

dbolduc added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2022

dbolduc marked this pull request as draft October 17, 2022 15:40

dbolduc added 4 commits October 27, 2022 21:58

feat: add mock library; w/ StreamRange

52656f6

cmake-format: sort

e4b5b09

install mocks?

d538fb5

testonly; install separate target

b722d1a

dbolduc force-pushed the feat-mocks-library branch from dfdff86 to b722d1a Compare October 28, 2022 01:58

dbolduc removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2022

dbolduc marked this pull request as ready for review October 28, 2022 02:01

No, there is another.

30a84cc

coryan reviewed Oct 28, 2022

View reviewed changes

address review comments

111bea4

coryan approved these changes Oct 28, 2022

View reviewed changes

dbolduc enabled auto-merge (squash) October 28, 2022 14:53

dbolduc merged commit 985768e into googleapis:main Oct 28, 2022

dbolduc deleted the feat-mocks-library branch October 28, 2022 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add mock library w/ StreamRange #9998

feat: add mock library w/ StreamRange #9998

dbolduc commented Oct 7, 2022 •

edited by coryan

Loading

google-cloud-cpp-bot commented Oct 7, 2022

codecov bot commented Oct 7, 2022 •

edited

Loading

coryan Oct 7, 2022

dbolduc Oct 8, 2022

dbolduc Oct 8, 2022

coryan Oct 12, 2022

dbolduc Oct 28, 2022

coryan Oct 28, 2022

google-cloud-cpp-bot commented Oct 8, 2022

google-cloud-cpp-bot commented Oct 8, 2022

google-cloud-cpp-bot commented Oct 8, 2022

devbww Oct 10, 2022

dbolduc Oct 28, 2022

google-cloud-cpp-bot commented Oct 28, 2022

google-cloud-cpp-bot commented Oct 28, 2022

coryan Oct 28, 2022

dbolduc Oct 28, 2022

coryan Oct 28, 2022

dbolduc Oct 28, 2022

coryan Oct 28, 2022

coryan left a comment

google-cloud-cpp-bot commented Oct 28, 2022

dbolduc commented Oct 28, 2022


		create_bazel_config(google_cloud_cpp_mocks YEAR "2022")

		google_cloud_cpp_install_headers("google_cloud_cpp_mocks"

feat: add mock library w/ StreamRange #9998

feat: add mock library w/ StreamRange #9998

Conversation

dbolduc commented Oct 7, 2022 • edited by coryan Loading

google-cloud-cpp-bot commented Oct 7, 2022

codecov bot commented Oct 7, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cloud-cpp-bot commented Oct 8, 2022

google-cloud-cpp-bot commented Oct 8, 2022

google-cloud-cpp-bot commented Oct 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cloud-cpp-bot commented Oct 28, 2022

google-cloud-cpp-bot commented Oct 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coryan left a comment

Choose a reason for hiding this comment

google-cloud-cpp-bot commented Oct 28, 2022

dbolduc commented Oct 28, 2022

dbolduc commented Oct 7, 2022 •

edited by coryan

Loading

codecov bot commented Oct 7, 2022 •

edited

Loading