Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): preserve ErrorInfo on retry errors #9971

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 3, 2022

Motivated by #9947


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d9dee735269f5b793cc9da36ec40b11d473873ca

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review October 3, 2022 22:17
@coryan coryan requested a review from a team as a code owner October 3, 2022 22:17
@coryan coryan enabled auto-merge (squash) October 3, 2022 22:17
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 94.21% // Head: 94.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d9dee73) compared to base (7fac832).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9971   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1500     1500           
  Lines      140573   140575    +2     
=======================================
+ Hits       132440   132448    +8     
+ Misses       8133     8127    -6     
Impacted Files Coverage Δ
google/cloud/internal/retry_loop_helpers.h 100.00% <ø> (ø)
google/cloud/internal/retry_loop_helpers.cc 100.00% <100.00%> (ø)
google/cloud/internal/retry_loop_helpers_test.cc 100.00% <100.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan merged commit 0f3b3eb into googleapis:main Oct 3, 2022
@coryan coryan deleted the fix-common-preserve-error-info-on-retry-errors branch October 4, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants