Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): respect MIME message boundary size limits #9965

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 2, 2022

Fixes #9961


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 2, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8fc93c1bedb75d3e715c96470eb2e94c95456fe9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 94.21% // Head: 94.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f966274) compared to base (6cda215).
Patch coverage: 96.84% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9965   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1497     1498    +1     
  Lines      140500   140549   +49     
=======================================
+ Hits       132370   132424   +54     
+ Misses       8130     8125    -5     
Impacted Files Coverage Δ
...loud/storage/internal/generate_message_boundary.cc 81.81% <81.81%> (ø)
...ge/internal/generate_message_boundary_benchmark.cc 97.95% <97.95%> (ø)
google/cloud/storage/internal/curl_client.cc 98.82% <100.00%> (-0.01%) ⬇️
...storage/internal/generate_message_boundary_test.cc 100.00% <100.00%> (ø)
google/cloud/storage/internal/rest_client.cc 73.90% <100.00%> (-0.12%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.75% <0.00%> (-0.57%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.34%) ⬇️
...cloud/storage/internal/generate_message_boundary.h
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.50%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 2, 2022 22:27
@coryan coryan requested a review from a team as a code owner October 2, 2022 22:27
google/cloud/storage/internal/generate_message_boundary.cc Outdated Show resolved Hide resolved
// L2 Unified 1024 KiB (x48)
// L3 Unified 39424 KiB (x2)
// ---------------------------------------------------------------------------------------------
// Benchmark Time CPU Iterations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinion: I usually think that the minimum is the best value to record (instead of mean or median) for such micro-benchmarks.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 696802b727cdf3e6171093f6129b3b1ca01afb1c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan force-pushed the fix-storage-limit-multipart-boundary branch from 696802b to f966274 Compare October 3, 2022 13:29
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f966274154ffc845858fda871bd267d18bc22303

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 7d08b5c into googleapis:main Oct 3, 2022
@coryan coryan deleted the fix-storage-limit-multipart-boundary branch October 3, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIME separators cannot exceed 70 characters
3 participants