Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): decay type before testing supported-options membership #9893

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(storage): decay type before testing supported-options membership #9893

merged 1 commit into from
Sep 22, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Sep 22, 2022 •
edited by coryan
Loading

Before we check whether ParallelUploadFileSupportedOptions contains a given type, we should remove any reference and top-level cv qualifiers. For example, ParallelUploadFile() supports UserIp const& just like it does UserIp.

This change is Reviewable

@devbww
fix(storage): decay type before testing supported-options membership
b630483 
Before we check whether `ParallelUploadFileSupportedOptions` contains a
given type, we should remove any reference and top-level cv qualifiers.
For example, `ParallelUploadFile()` supports `UserIp const&` just like
it does `UserIp`.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 22, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b630483e747e41e47ead921b08acfa8e8dce73b5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited
Loading

Codecov Report

Base: 94.17% // Head: 94.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b630483) compared to base (6390ed1).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9893   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files        1495     1495           
  Lines      140051   140051           
=======================================
+ Hits       131895   131898    +3     
+ Misses       8156     8153    -3
Impacted Files Coverage Δ
google/cloud/storage/parallel_upload.h 97.09% <ø> (ø)
google/cloud/storage/parallel_upload.cc 98.26% <0.00%> (-0.35%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.34%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.17%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
...e/cloud/spanner/testing/cleanup_stale_instances.cc 75.40% <0.00%> (+6.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww marked this pull request as ready for review September 22, 2022 08:49
@devbww devbww requested a review from a team as a code owner September 22, 2022 08:49
@devbww devbww merged commit 5efef78 into googleapis:main Sep 22, 2022
@devbww devbww deleted the type-list-filter branch September 22, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devbww @google-cloud-cpp-bot @dbolduc