Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support for CMMR phase 2 #9872

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Sep 19, 2022

Tests and samples for user-managed instance configurations.


This change is Reviewable

Tests and samples for user-managed instance configurations.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Sep 19, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 19, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7d758772a168282e5c754364be348e9547b85182

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 94.24% // Head: 94.17% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (7d75877) compared to base (4bb4dec).
Patch coverage: 27.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9872      +/-   ##
==========================================
- Coverage   94.24%   94.17%   -0.07%     
==========================================
  Files        1495     1495              
  Lines      139838   139981     +143     
==========================================
+ Hits       131787   131824      +37     
- Misses       8051     8157     +106     
Impacted Files Coverage Δ
google/cloud/spanner/samples/samples.cc 62.86% <12.72%> (-2.25%) ⬇️
...ogle/cloud/spanner/testing/pick_instance_config.cc 78.94% <50.00%> (-3.41%) ⬇️
...e/cloud/spanner/testing/cleanup_stale_instances.cc 73.84% <75.86%> (+1.62%) ⬆️
...ogle/cloud/spanner/testing/random_instance_name.cc 100.00% <100.00%> (ø)
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.68%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww marked this pull request as ready for review September 19, 2022 17:35
@devbww devbww requested a review from a team as a code owner September 19, 2022 17:35
}
}
}
// Let it fail if we have too many leaks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am Okay with this, but curious about the rationale. Seems like an opportunity for flakes that we do not need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. At the moment I am only duplicating the behavior of CleanupStaleInstances(), which I didn't originate, but I will more than happily followup by removing both cases. Thanks.

@devbww devbww merged commit 181ebfb into googleapis:main Sep 19, 2022
@devbww devbww deleted the read-only-replicas branch September 19, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants