-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add support for CMMR phase 2 #9872
Conversation
Tests and samples for user-managed instance configurations.
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.24% // Head: 94.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9872 +/- ##
==========================================
- Coverage 94.24% 94.17% -0.07%
==========================================
Files 1495 1495
Lines 139838 139981 +143
==========================================
+ Hits 131787 131824 +37
- Misses 8051 8157 +106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
} | ||
} | ||
} | ||
// Let it fail if we have too many leaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am Okay with this, but curious about the rationale. Seems like an opportunity for flakes that we do not need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. At the moment I am only duplicating the behavior of CleanupStaleInstances()
, which I didn't originate, but I will more than happily followup by removing both cases. Thanks.
Tests and samples for user-managed instance configurations.
This change is