feat(storage): improve error messages on stalled uploads #9744
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9744 +/- ##
==========================================
- Coverage 93.87% 93.87% -0.01%
==========================================
Files 1498 1498
Lines 139564 139588 +24
==========================================
+ Hits 131016 131036 +20
- Misses 8548 8552 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
| @@ -154,6 +154,42 @@ bool UploadChunkOnFailure(RetryPolicy& retry_policy, int& count, | |||
| return retry_policy.OnFailure(status); | |||
| } | |||
|
|
|||
| Status RetryError(Status const& last_status, RetryPolicy const& retry_policy, | |||
| char const* error_message) { | |||
There was a problem hiding this comment.
error_message seems a little misleading in the context of "... in <error_message>".
Previously we seem to have used char const* location or char const* function_name.
| std::ostringstream os; | ||
| os << "All requests (" << upload_count << ") have succeeded, but they have" | ||
| << " not completed the full write. The expected committed size is " | ||
| << expected_committed_size << " the current committed size is " |
| @@ -494,8 +530,10 @@ StatusOr<EmptyResponse> RetryClient::DeleteResumableUpload( | |||
| // | |||
| StatusOr<QueryResumableUploadResponse> RetryClient::UploadChunk( | |||
| UploadChunkRequest const& request) { | |||
| Status last_status(StatusCode::kDeadlineExceeded, | |||
| "Retry policy exhausted before first attempt was made."); | |||
| auto const initial_status = | |||
There was a problem hiding this comment.
initial_status seems to be unused.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This change is