Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group GUAC Options in an OptionsList #9643

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 7, 2022

Fixes #8240

Add an OptionsList for the GUAC Options and check for it in generated and hand-written connections. (Unless the handwritten connection is deprecated).

Also add a missing OptionsList and Options from the expected Bigtable options


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 74da70bc6a54ff0c71dc51c014bb1717eca2c715

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc force-pushed the guac-options-list branch from 74da70b to a4badb9 Compare August 7, 2022 02:45
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a4badb9d0f638f67f09e9d7e7b87406a1b4b0849

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #9643 (a4badb9) into main (2bb2d02) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9643      +/-   ##
==========================================
- Coverage   94.35%   94.34%   -0.01%     
==========================================
  Files        1493     1493              
  Lines      138539   138539              
==========================================
- Hits       130713   130711       -2     
- Misses       7826     7828       +2     
Impacted Files Coverage Δ
...ion_tests/golden/golden_kitchen_sink_connection.cc 30.30% <ø> (ø)
...tion_tests/golden/golden_kitchen_sink_connection.h 100.00% <ø> (ø)
...tion_tests/golden/golden_thing_admin_connection.cc 20.00% <ø> (ø)
...ation_tests/golden/golden_thing_admin_connection.h 100.00% <ø> (ø)
generator/internal/connection_generator.cc 59.54% <ø> (ø)
google/cloud/bigtable/data_connection.h 100.00% <ø> (ø)
google/cloud/pubsub/schema_admin_connection.cc 90.38% <ø> (ø)
...ogle/cloud/pubsub/subscription_admin_connection.cc 83.08% <ø> (ø)
google/cloud/pubsub/topic_admin_connection.cc 85.39% <ø> (ø)
google/cloud/bigtable/data_connection.cc 28.30% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 7, 2022 15:26
@dbolduc dbolduc requested a review from a team as a code owner August 7, 2022 15:26
@dbolduc dbolduc merged commit 70dbee5 into googleapis:main Aug 7, 2022
@dbolduc dbolduc deleted the guac-options-list branch August 7, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious warning in BigQuery client
3 participants