Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: heed abseil-string-find-startswith clang-tidy #9416

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Jul 2, 2022

Some downstream users enable this clang-tidy, so we might as well take
its advice.

https://clang.llvm.org/extra/clang-tidy/checks/abseil/string-find-startswith.html


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 77ddb1ba960c0e2b61c1168d99121733f47d4cbe

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #9416 (77ddb1b) into main (c23bcf2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9416   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files        1484     1484           
  Lines      136115   136116    +1     
=======================================
+ Hits       128779   128780    +1     
  Misses       7336     7336           
Impacted Files Coverage Δ
...gle/cloud/pubsub/internal/exactly_once_policies.cc 100.00% <100.00%> (ø)
.../cloud/pubsub/internal/extend_leases_with_retry.cc 95.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.24% <0.00%> (-0.69%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (ø)
google/cloud/pubsub/samples/samples.cc 92.18% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23bcf2...77ddb1b. Read the comment docs.

@devbww devbww marked this pull request as ready for review July 2, 2022 08:38
@devbww devbww requested a review from a team as a code owner July 2, 2022 08:38
@devbww devbww merged commit 6a7c0a8 into googleapis:main Jul 2, 2022
@devbww devbww deleted the abseil-string-find-startswith branch July 2, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants