Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pubsub): improve documentation for *AckHandler #9404

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 30, 2022

From: #9394 (review)

That motivated some other small changes.


This change is Reviewable

@coryan coryan requested a review from devbww June 30, 2022 22:47
@coryan coryan requested a review from a team as a code owner June 30, 2022 22:47
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 30, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 883600fb76acd3e9f47268b2616b06820be00af2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #9404 (883600f) into main (28610e6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9404   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1485     1485           
  Lines      136006   136006           
=======================================
+ Hits       128669   128675    +6     
+ Misses       7337     7331    -6     
Impacted Files Coverage Δ
google/cloud/pubsub/ack_handler.h 80.00% <ø> (ø)
...e/cloud/pubsub/internal/exactly_once_ack_handler.h 70.58% <ø> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28610e6...883600f. Read the comment docs.

@coryan coryan merged commit 9fd6820 into googleapis:main Jul 1, 2022
@coryan coryan deleted the doc-pubsub-exactly-once-delivery-pr7.1 branch July 1, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants