-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigtable): modern Table
constructor
#9403
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9403 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 1485 1485
Lines 136006 136008 +2
=======================================
+ Hits 128669 128677 +8
+ Misses 7337 7331 -6
Continue to review full report at Codecov.
|
7f75d60
to
f2db272
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
/gcbrun |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Another build failed to trigger. We go again. |
/gcbrun |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
oh duh, because the trigger is disabled... |
/gcbrun |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fixes #8860
Technically this fixes #6465 which fixes #1161. Although we should probably update our credentials sample. (I think of that task as #7434).
Release the
Table
constructor that accepts aDataConnection
. Yay, we are close to having a good mocking story. and a good credentials story. (I say close because there is still the pesky legacy API which does not have these things and lives alongside the "new shinny").For now I just list the relevant options in the constructor's documentation. I would like to link to examples of how the
Options
are used. But the examples must exist first. (#9309 tracks this work).I would also like to provide guidance on how to mock the
Table
calls in this constructor's documentation. (which is blocked on #9308).I think this feature warrants a detailed CHANGELOG entry, but I am going to wait until the other modernization work is done before writing the post.
This change is