Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9373
Note that any test in Bigtable (the only service with explicit routing for which we have a library) which sets an app profile id will now fail the context metadata check. There is apparently exactly one such test, so we implement a temporary workaround.
My plan is to add more such tests by also setting the app profile id in the
bigtable_stub_factory_test.cc
.But this will have to wait until after the generator has explicit routing support.
google-cloud-cpp/google/cloud/bigtable/internal/bigtable_stub_factory_test.cc
Lines 117 to 119 in 91aae8c
This change is