Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: validate explicit routing #9385

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 29, 2022

Fixes #9373

Note that any test in Bigtable (the only service with explicit routing for which we have a library) which sets an app profile id will now fail the context metadata check. There is apparently exactly one such test, so we implement a temporary workaround.

My plan is to add more such tests by also setting the app profile id in the bigtable_stub_factory_test.cc.
But this will have to wait until after the generator has explicit routing support.

google::bigtable::v2::ReadRowsRequest req;
req.set_table_name(
"projects/the-project/instances/the-instance/tables/the-table");


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d8fff54bcab8452d5a3e41c3e99332d48c250457

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #9385 (d8fff54) into main (55f0da0) will decrease coverage by 0.00%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##             main    #9385      +/-   ##
==========================================
- Coverage   94.68%   94.68%   -0.01%     
==========================================
  Files        1480     1480              
  Lines      135457   135483      +26     
==========================================
+ Hits       128258   128276      +18     
- Misses       7199     7207       +8     
Impacted Files Coverage Δ
google/cloud/testing_util/validate_metadata.cc 91.48% <81.48%> (-2.38%) ⬇️
.../cloud/bigtable/internal/legacy_row_reader_test.cc 100.00% <100.00%> (ø)
...loud/bigtable/internal/connection_refresh_state.cc 97.22% <0.00%> (-2.78%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f0da0...d8fff54. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 29, 2022 22:54
@dbolduc dbolduc requested a review from a team as a code owner June 29, 2022 22:54
@dbolduc dbolduc merged commit ec741cb into googleapis:main Jun 30, 2022
@dbolduc dbolduc deleted the validate-explicit-routing branch June 30, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing_util::ValidateMetadataFixture should respect explicit routing
3 participants