feat(bigtable): add AppProfileIdOption
#9382
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9382 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 1480 1480
Lines 135574 135579 +5
==========================================
+ Hits 128354 128355 +1
- Misses 7220 7224 +4
Continue to review full report at Codecov.
|
google/cloud/bigtable/table.h
Outdated
| @@ -37,6 +37,7 @@ | |||
| #include "google/cloud/status.h" | |||
| #include "google/cloud/status_or.h" | |||
| #include "absl/meta/type_traits.h" | |||
| #include "options.h" | |||
There was a problem hiding this comment.
s/"options.h"/"google/cloud/options.h"/
google/cloud/bigtable/options.h
Outdated
| @@ -51,6 +51,15 @@ namespace cloud { | |||
| namespace bigtable { | |||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN | |||
|
|
|||
| /** | |||
| * The application profile id needed for using the replication API. | |||
There was a problem hiding this comment.
"Option" and "needed" sound like opposites.
There was a problem hiding this comment.
Lol. It is needed to use an optional feature. I updated the comment to avoid this confusion.
(not related to your comment, but) I also added some more information on app profiles.
google/cloud/bigtable/table.h
Outdated
| @@ -37,6 +37,7 @@ | |||
| #include "google/cloud/status.h" | |||
| #include "google/cloud/status_or.h" | |||
| #include "absl/meta/type_traits.h" | |||
| #include "options.h" | |||
| Options options = {}) | ||
| : app_profile_id_(std::move(app_profile_id)), | ||
| std::string table_id, Options options = {}) | ||
| : app_profile_id_(options.get<AppProfileIdOption>()), |
There was a problem hiding this comment.
Should this wait until options_ is constructed?
There was a problem hiding this comment.
It won't matter. The plan is to remove app_profile_id_ in a future PR, and have options_ be the only place the value is stored. I felt this intermediate state was a decent way to break down the changes.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Part of the work for #9349
For now, if the
AppProfileIdOptionis supplied to theTableconstructor, we copy the value intoTable::app_profile_id_, and pass that along to the Connection when a call is made.In a follow up PR, I will modify the Connection API to drop the
app_profile_idargument from its calls, and instead look for the value inCurrentOptions(). I think I will dropTable::app_profile_id_in that PR as well.This change is