feat(common): truncation support for plain strings in the RPC log #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `DebugString(std::string, TracingOptions const&)` for adding a plain string to the RPC log, but with the `truncate_string_field_longer_than` behavior of `google::protobuf::TextFormat::Printer`. This will be used in an upcoming change that will log a `resume_token` from the Spanner streaming read/query protocol, and which is extremely long.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9351 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 1470 1470
Lines 134809 134820 +11
=======================================
+ Hits 127601 127615 +14
+ Misses 7208 7205 -3
Continue to review full report at Codecov.
|
coryan
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww)
devbww
added a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Jun 28, 2022
Add a cast to the `int64_t`-to-`size_t` conversion from googleapis#9351.
devbww
added a commit
that referenced
this pull request
Jun 28, 2022
Add a cast to the `int64_t`-to-`size_t` conversion from #9351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DebugString(std::string, TracingOptions const&)for adding a plainstring to the RPC log, but with the
truncate_string_field_longer_thanbehavior of
google::protobuf::TextFormat::Printer.This will be used in an upcoming change that will log a
resume_tokenfrom the Spanner streaming read/query protocol, and which is extremely
long.
This change is