Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): introduce DataConnection #9323

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 21, 2022

Part of the work for #8860


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 21, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: daf722d8b6b9e895c6eeb675f2c9cf809736db99

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #9323 (78ffae1) into main (ff90f3e) will increase coverage by 0.00%.
The diff coverage is 48.38%.

@@           Coverage Diff           @@
##             main    #9323   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1470     1470           
  Lines      134686   134685    -1     
=======================================
+ Hits       127419   127421    +2     
+ Misses       7267     7264    -3     
Impacted Files Coverage Δ
google/cloud/bigtable/data_connection.h 100.00% <ø> (ø)
...gle/cloud/bigtable/internal/data_connection_impl.h 100.00% <ø> (ø)
google/cloud/bigtable/mocks/mock_data_connection.h 100.00% <ø> (ø)
...le/cloud/bigtable/testing/table_integration_test.h 68.18% <ø> (ø)
google/cloud/bigtable/data_connection.cc 16.98% <11.11%> (ø)
google/cloud/bigtable/table.h 99.22% <100.00%> (ø)
...e/cloud/bigtable/testing/table_integration_test.cc 80.87% <100.00%> (ø)
...ogle/cloud/bigtable/tests/data_integration_test.cc 97.72% <100.00%> (ø)
...gtable/tests/table_sample_rows_integration_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff90f3e...78ffae1. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 78ffae1c5c31faa02c058a28931a7c44250d2375

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review June 21, 2022 23:06
@dbolduc dbolduc requested a review from a team as a code owner June 21, 2022 23:06
@dbolduc dbolduc merged commit 0673b95 into googleapis:main Jun 23, 2022
@dbolduc dbolduc deleted the bigtable-modern-data-connection branch June 23, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants