test(spanner): remove database_dialect workaround for CreateDatabase #9029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting of `database_dialect` in the `CreateDatabase()` result has been fixed. `RestoreDatabase()`, however, remains an issue. Part of googleapis#8573.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9029 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 1421 1421
Lines 125219 125219
=======================================
Hits 118304 118304
Misses 6915 6915 Continue to review full report at Codecov.
|
scotthart
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting of
database_dialectin theCreateDatabase()result hasbeen fixed.
RestoreDatabase(), however, remains an issue.Part of #8573.
This change is