Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Add ability to restore soft deleted objects #14710

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Sep 16, 2024

Fixes: #13575

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 16, 2024
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review September 17, 2024 00:12
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners September 17, 2024 00:12
@ddelgrosso1
Copy link
Contributor Author

This should be the final piece of #13575 (RestoreObject).

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (43f595c) to head (73998fd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/storage/idempotency_policy.h 0.00% 2 Missing ⚠️
...gle/cloud/storage/internal/generic_stub_adapter.cc 0.00% 2 Missing ⚠️
google/cloud/storage/internal/grpc/stub_test.cc 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14710      +/-   ##
==========================================
+ Coverage   93.49%   93.50%   +0.01%     
==========================================
  Files        2323     2323              
  Lines      207758   207993     +235     
==========================================
+ Hits       194243   194484     +241     
+ Misses      13515    13509       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end.

google/cloud/storage/client.h Show resolved Hide resolved
google/cloud/storage/client.h Show resolved Hide resolved
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 32 files at r1.
Reviewable status: 10 of 32 files reviewed, 4 unresolved discussions (waiting on @bajajneha27 and @ddelgrosso1)


google/cloud/storage/internal/object_requests.h line 391 at r1 (raw file):

 public:
  RestoreObjectRequest() = default;
  explicit RestoreObjectRequest(std::string bucket_name,

explicit is unnecessary here as the constructor has more than one parameter.

@ddelgrosso1 ddelgrosso1 merged commit 47b18cd into googleapis:main Sep 18, 2024
70 of 71 checks passed
@ddelgrosso1 ddelgrosso1 deleted the object-restore branch September 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: implement soft delete feature
3 participants