-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): Add ability to restore soft deleted objects #14710
Conversation
a9bb406
to
90769ec
Compare
This should be the final piece of #13575 (RestoreObject). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14710 +/- ##
==========================================
+ Coverage 93.49% 93.50% +0.01%
==========================================
Files 2323 2323
Lines 207758 207993 +235
==========================================
+ Hits 194243 194484 +241
+ Misses 13515 13509 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 32 files at r1.
Reviewable status: 10 of 32 files reviewed, 4 unresolved discussions (waiting on @bajajneha27 and @ddelgrosso1)
google/cloud/storage/internal/object_requests.h
line 391 at r1 (raw file):
public: RestoreObjectRequest() = default; explicit RestoreObjectRequest(std::string bucket_name,
explicit
is unnecessary here as the constructor has more than one parameter.
Fixes: #13575
This change is