fix: respect GOOGLE_CLOUD_QUOTA_PROJECT
#14684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://google.aip.dev/auth/4110 says we should have used the env var
GOOGLE_CLOUD_QUOTA_PROJECT
instead of making up our ownGOOGLE_CLOUD_CPP_USER_PROJECT
.So we will respect both.
Note that this is separate from our
QuotaUserOption
which sets thex-goog-quota-user
header. Confusing stuff.I do not think we need to publicize the new form of the env var.
This change is