Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect GOOGLE_CLOUD_QUOTA_PROJECT #14684

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 5, 2024

https://google.aip.dev/auth/4110 says we should have used the env var GOOGLE_CLOUD_QUOTA_PROJECT instead of making up our own GOOGLE_CLOUD_CPP_USER_PROJECT.

So we will respect both.

Note that this is separate from our QuotaUserOption which sets the x-goog-quota-user header. Confusing stuff.

I do not think we need to publicize the new form of the env var.


This change is Reviewable

@dbolduc dbolduc changed the title feat: respect GOOGLE_CLOUD_QUOTA_PROJECT fix: respect GOOGLE_CLOUD_QUOTA_PROJECT Sep 5, 2024
@dbolduc dbolduc added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (da56bf9) to head (7bb8cd0).
Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14684   +/-   ##
=======================================
  Coverage   93.61%   93.62%           
=======================================
  Files        2320     2320           
  Lines      207188   207197    +9     
=======================================
+ Hits       193966   193981   +15     
+ Misses      13222    13216    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 9, 2024
@dbolduc dbolduc marked this pull request as ready for review September 9, 2024 14:59
@dbolduc dbolduc requested a review from a team as a code owner September 9, 2024 14:59
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 848c622 into googleapis:main Sep 9, 2024
72 checks passed
@dbolduc dbolduc deleted the quota-project-env-var branch September 9, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants