docs: create a few code snippets as examples for using Spanner Graph using cpp #14660
Conversation
|
Here is the summary of changes. You are about to add 9 region tags.
This comment is generated by snippet-bot.
|
|
/gcbrun |
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @bharadwajvr)
google/cloud/spanner/samples/graph_samples.cc line 43 at r2 (raw file):
//! [START spanner_create_database_with_property_graph] void CreateDatabaseWithPropertyGraph( google::cloud::spanner_admin::DatabaseAdminClient client,
Looks like there's some formatting that needs be applied. Running ci/cloudbuild/build.sh -t checkers-pr locally should take care of it.
google/cloud/spanner/samples/graph_samples.cc line 419 at r2 (raw file):
using CommandMap = std::map<std::string, CommandType>; using SampleFunction = void (*)(google::cloud::spanner::Client);
Prefer using std::function instead of C style function pointers, here and elsewhere:
using SampleFunction = std::function<void(google::cloud::spanner::Client)>;
google/cloud/spanner/samples/spanner_client_integration_samples.bzl line 15 at r2 (raw file):
# limitations under the License. # # DO NOT EDIT -- GENERATED BY CMake -- Change the CMakeLists.txt file if needed
You'll want to edit spanner/samples/CMakeLists.txt to add graph_samples.cc
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @scotthart)
google/cloud/spanner/samples/graph_samples.cc line 43 at r2 (raw file):
Previously, scotthart (Scott Hart) wrote…
Looks like there's some formatting that needs be applied. Running
ci/cloudbuild/build.sh -t checkers-prlocally should take care of it.
I tried this and I run into compilation errors in typos-cli v1.16.1 - errors E0277, E0308.
Googling didn't help me find a fix. Is this something you recognize and can help me fix?
google/cloud/spanner/samples/graph_samples.cc line 419 at r2 (raw file):
Previously, scotthart (Scott Hart) wrote…
Prefer using
std::functioninstead of C style function pointers, here and elsewhere:using SampleFunction = std::function<void(google::cloud::spanner::Client)>;
Done.
google/cloud/spanner/samples/spanner_client_integration_samples.bzl line 15 at r2 (raw file):
Previously, scotthart (Scott Hart) wrote…
You'll want to edit
spanner/samples/CMakeLists.txtto addgraph_samples.cc
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @scotthart)
google/cloud/spanner/samples/graph_samples.cc line 43 at r2 (raw file):
Previously, bharadwajvr wrote…
I tried this and I run into compilation errors in typos-cli v1.16.1 - errors E0277, E0308.
Googling didn't help me find a fix. Is this something you recognize and can help me fix?
Rebased to updated main and that fixed the problem. Formatting changes are applied now.
|
/gcbrun |
|
Gentle reminder: @scotthart |
|
/gcbrun |
…o it returns non-zero rows
…_samples to CMakeLists
|
/gcbrun |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14660 +/- ##
==========================================
- Coverage 93.62% 93.49% -0.13%
==========================================
Files 2320 2321 +1
Lines 207209 207513 +304
==========================================
+ Hits 193997 194019 +22
- Misses 13212 13494 +282 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Ignoring the code-coverage data here since this is sample code.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @scotthart)
Add a few code snippets to illustrate how to use Spanner Graph functionality in Java. These examples resemble other snippets for how various other Spanner features can be used.
Fixes #14659
This change is