refactor: bazel gapic helper #14173
Merged
refactor: bazel gapic helper #14173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14173 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 2206 2206
Lines 192058 192059 +1
=======================================
+ Hits 179074 179075 +1
Misses 12984 12984 ☔ View full report in Codecov by Sentry. |
|
brb. I should update the scaffolding in this PR. |
devbww
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interesting part of #14171
Add a helper to handle most of the
BUILD.bazeldefinitions.Demonstrate how to use the helper in one library.
This change is