Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): remove topic and subscription handwritten admin api helper functions #13742

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Mar 7, 2024

#12987

This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 7, 2024
@alevenberg alevenberg marked this pull request as ready for review March 8, 2024 16:28
@alevenberg alevenberg requested a review from a team as a code owner March 8, 2024 16:28
@alevenberg
Copy link
Member Author

Ready for review @devbww

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (453db12) to head (df23bfe).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13742      +/-   ##
==========================================
- Coverage   93.26%   93.26%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193012   192950      -62     
==========================================
- Hits       180012   179953      -59     
+ Misses      13000    12997       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit 5f42238 into googleapis:main Mar 8, 2024
62 checks passed
@alevenberg alevenberg deleted the remove branch March 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants