Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): deprecate the subscription admin handwritten api #13736

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Mar 6, 2024

#12987

Updated changelog in #13731

This change is Reviewable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alevenberg alevenberg requested a review from a team as a code owner March 6, 2024 14:13
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (2f1bff2) to head (20e3c72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13736      +/-   ##
==========================================
- Coverage   93.27%   93.26%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193091   193012      -79     
==========================================
- Hits       180098   180018      -80     
- Misses      12993    12994       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit 6e8b974 into googleapis:main Mar 6, 2024
62 checks passed
@alevenberg alevenberg deleted the sub-dep branch March 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants