Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): move sub admin to generated in integration test #13701

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Feb 29, 2024

Part of #12987


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 29, 2024
@alevenberg alevenberg marked this pull request as ready for review March 5, 2024 19:36
@alevenberg alevenberg requested a review from a team as a code owner March 5, 2024 19:36
@alevenberg alevenberg enabled auto-merge (squash) March 5, 2024 19:38
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (98f8e99) to head (0f072d0).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13701   +/-   ##
=======================================
  Coverage   93.25%   93.26%           
=======================================
  Files        2229     2229           
  Lines      193277   193284    +7     
=======================================
+ Hits       180249   180260   +11     
+ Misses      13028    13024    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit 06e73fe into googleapis:main Mar 5, 2024
62 checks passed
@alevenberg alevenberg deleted the stuff branch March 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants