Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support listing folders as prefixes #13683

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 28, 2024

Part of the work for #13561


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 28, 2024
@coryan coryan marked this pull request as ready for review February 28, 2024 22:46
@coryan coryan requested a review from a team as a code owner February 28, 2024 22:46
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 93.27%. Comparing base (8e7f422) to head (05e5ecd).
Report is 1 commits behind head on main.

Files Patch % Lines
...gle/cloud/storage/tests/object_integration_test.cc 7.14% 26 Missing ⚠️
...e/cloud/storage/examples/storage_object_samples.cc 5.55% 17 Missing ⚠️
google/cloud/storage/include_folders_as_prefixes.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13683      +/-   ##
==========================================
- Coverage   93.30%   93.27%   -0.03%     
==========================================
  Files        2228     2229       +1     
  Lines      193366   193414      +48     
==========================================
+ Hits       180411   180415       +4     
- Misses      12955    12999      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan force-pushed the feat-storage-support-listing-folders branch from 8460445 to 05e5ecd Compare February 29, 2024 12:13
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 33be7d2 into googleapis:main Feb 29, 2024
63 checks passed
@coryan coryan deleted the feat-storage-support-listing-folders branch February 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants