Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): remove handwritten subscription api samples #13682

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Feb 28, 2024

#12987

Note:

  • Samples exists in subscription_admin_samples.cc now
  • I moved the tag in google3 already.
  • Some of the delete's are not ordered anymore (1,2,3...). They will eventually all be gone so this does not matter.

This change is Reviewable

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (16319a7) to head (0507136).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13682      +/-   ##
==========================================
- Coverage   93.26%   93.25%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193299   193199     -100     
==========================================
- Hits       180272   180175      -97     
+ Misses      13027    13024       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg marked this pull request as ready for review February 29, 2024 19:50
@alevenberg alevenberg requested a review from a team as a code owner February 29, 2024 19:50
Copy link

snippet-bot bot commented Feb 29, 2024

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alevenberg
Copy link
Member Author

This PR is ready for review

@alevenberg alevenberg merged commit 9ab54c0 into googleapis:main Mar 5, 2024
62 checks passed
@alevenberg alevenberg deleted the pubsub-clean branch March 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants