Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): remove handwritten create subscription from samples.cc #13676

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Feb 28, 2024

#12987

Exists in subscription_admin_samples.cc now

Also, moved the tag in google3 already.

This change is Reviewable

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Feb 28, 2024
@alevenberg alevenberg marked this pull request as ready for review February 28, 2024 16:53
@alevenberg alevenberg requested a review from a team as a code owner February 28, 2024 16:53
Copy link

snippet-bot bot commented Feb 28, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 93.30%. Comparing base (f0af9a3) to head (c218952).

Files Patch % Lines
google/cloud/pubsub/samples/samples.cc 64.28% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13676   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files        2228     2228           
  Lines      193359   193366    +7     
=======================================
+ Hits       180404   180412    +8     
+ Misses      12955    12954    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

google/cloud/pubsub/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/samples/samples.cc Show resolved Hide resolved
@alevenberg alevenberg merged commit 8f7b665 into googleapis:main Feb 28, 2024
62 checks passed
@alevenberg alevenberg deleted the remove-sub branch February 28, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants