Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): support request_id-like fields #13615

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 15, 2024

With this change the generator populates the request_id-like fields
and also uses the field to determine if a request is idempotent.

Fixes #13595


This change is Reviewable

With this change the generator populates the `request_id`-like fields
and also uses the field to determine if a request is idempotent.
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (52b00ee) 93.25% compared to head (fedfab9) 93.25%.
Report is 1 commits behind head on main.

Files Patch % Lines
generator/internal/connection_impl_generator.cc 30.00% 7 Missing ⚠️
generator/internal/idempotency_policy_generator.cc 0.00% 6 Missing ⚠️
...ion_tests/tests/request_id_connection_impl_test.cc 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13615      +/-   ##
==========================================
- Coverage   93.25%   93.25%   -0.01%     
==========================================
  Files        2223     2223              
  Lines      193242   193281      +39     
==========================================
+ Hits       180210   180244      +34     
- Misses      13032    13037       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review February 15, 2024 15:10
@coryan coryan requested a review from a team as a code owner February 15, 2024 15:10
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 4 of 4 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 9ea3fb2 into googleapis:main Feb 15, 2024
61 checks passed
@coryan coryan deleted the feat-generator-support-request-id-fields branch February 15, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically populate request_id-like fields to make requests idempotent
2 participants