Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): add tags to topic admin samples #13590

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Feb 12, 2024

Part of #12987

This change is Reviewable

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Feb 12, 2024
@alevenberg alevenberg marked this pull request as ready for review February 12, 2024 18:48
@alevenberg alevenberg requested a review from a team as a code owner February 12, 2024 18:48
Copy link

snippet-bot bot commented Feb 12, 2024

Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9843c5) 93.29% compared to head (267ce22) 93.28%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13590      +/-   ##
==========================================
- Coverage   93.29%   93.28%   -0.01%     
==========================================
  Files        2197     2197              
  Lines      192012   192009       -3     
==========================================
- Hits       179128   179124       -4     
- Misses      12884    12885       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg enabled auto-merge (squash) February 12, 2024 19:40
@alevenberg alevenberg merged commit 01a0722 into googleapis:main Feb 14, 2024
60 checks passed
@alevenberg alevenberg deleted the topic branch February 14, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants