feat(spanner): add support for max commit delay #13562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13562 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 2228 2228
Lines 193366 193421 +55
=======================================
+ Hits 180411 180467 +56
+ Misses 12955 12954 -1 ☔ View full report in Codecov by Sentry. |
|
@devbww - Looks like there was a small gap in the unit testing - this is now fixed. PTAL. |
|
/gcbrun |
1 similar comment
|
/gcbrun |
devbww
reviewed
Feb 12, 2024
…-cloud-cpp into max-commit-delay
|
/gcbrun |
1 similar comment
|
/gcbrun |
devbww
reviewed
Feb 13, 2024
…-cloud-cpp into max-commit-delay
|
/gcbrun |
devbww
reviewed
Feb 14, 2024
|
Navarre: FYI ... We'll be cutting a google-cloud-cpp release on March 4, and then not again until April 12, so if you want this to appear in a numbered/tagged release before April 12, it will need to be merged in the next few days. |
|
Hey Bradley,
Thanks for the heads up! Sorry for the delay and duly noted - I will get
this turned around to you tomorrow.
Thanks,
N
…On Wed, Feb 28, 2024 at 7:56 PM Bradley White ***@***.***> wrote:
Navarre: FYI ... We'll be cutting a google-cloud-cpp release on March 4,
and then not again until April 12, so if you want this to appear in a
numbered/tagged release before April 12, it will need to be merged in the
next few days.
—
Reply to this email directly, view it on GitHub
<#13562 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7M4QVKREBQZOGI7THG77VTYV735XAVCNFSM6AAAAABC465YH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGM2TCNJRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
@devbww - I've addressed the remaining comments. Sorry again for the delay.
|
/gcbrun |
devbww
reviewed
Feb 29, 2024
|
/gcbrun |
devbww
reviewed
Feb 29, 2024
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is