fix(pubsub): install admin mocks #13537
Merged
+7
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #5782
We were copying all of the mock files into both
include/google/cloud/pubsub/mocks
andinclude/google/cloud/pubsub/admin/mocks
, without preserving the relative directory structure.The handwritten and generated admin mock files have the same name, so I think we would first install the generated admin mocks (because they were first in the list), then we would overwrite them with the handwritten admin mocks.
Before:
After:
Note that we are going to need to use the
$<BUILD_INTERFACE:...>
generator expression in order to install our other mocks too.This change is