Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pubsub): use the clock class instead of a lambda #13389

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 3, 2024
@alevenberg alevenberg added the do not review Indicates a PR is not ready for review label Jan 3, 2024
@alevenberg alevenberg changed the title impl(pubsub): start lease manager in ack handler feat(pubsub): add lease management for unary pull Jan 8, 2024
@alevenberg alevenberg removed the do not review Indicates a PR is not ready for review label Jan 8, 2024
@alevenberg alevenberg marked this pull request as ready for review January 8, 2024 17:41
@alevenberg alevenberg requested a review from a team as a code owner January 8, 2024 17:41
@alevenberg alevenberg marked this pull request as draft January 8, 2024 18:12
@alevenberg alevenberg changed the title feat(pubsub): add lease management for unary pull refactor(pubsub): use the clock class instead of a lambda Jan 10, 2024
@alevenberg alevenberg marked this pull request as ready for review January 10, 2024 22:10
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a938ab) 93.09% compared to head (dc5e215) 93.10%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13389   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files        2164     2164           
  Lines      188858   188857    -1     
=======================================
+ Hits       175824   175826    +2     
+ Misses      13034    13031    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit db22daa into googleapis:main Jan 12, 2024
60 checks passed
@alevenberg alevenberg deleted the hey-7 branch January 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants