-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(pubsub): add default pull lease manager class #13365
impl(pubsub): add default pull lease manager class #13365
Conversation
7998f4e
to
f6c00b3
Compare
f6c00b3
to
bcc7127
Compare
bcc7127
to
3ae9e31
Compare
3ae9e31
to
35f5880
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13365 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 2143 2143
Lines 187144 187144
=======================================
+ Hits 174171 174173 +2
+ Misses 12973 12971 -2 ☔ View full report in Codecov by Sentry. |
@@ -1,4 +1,4 @@ | |||
// Copyright 2022 Google LLC | |||
// Copyright 2023 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I am not sure we /need/ to update the copyright year here. I think you can, but it may be worthwhile to revisit go/releasing.
Part of #13298
These are exact copies of the PullLeaseManager except with s/pull_lease_manager/default_pull_lease_manager and other variations.
In the next PR, I will turn PullLeaseManager into an interface so the PullAckHandler can hold either a DefaultPullLeaseManager or a TracingPullLeaseManager{DefaultPullLeaseManager}
1/2 in a chain
This change is