Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(pubsub): add default pull lease manager class #13365

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Dec 27, 2023

Part of #13298

These are exact copies of the PullLeaseManager except with s/pull_lease_manager/default_pull_lease_manager and other variations.

In the next PR, I will turn PullLeaseManager into an interface so the PullAckHandler can hold either a DefaultPullLeaseManager or a TracingPullLeaseManager{DefaultPullLeaseManager}

1/2 in a chain

  1. impl(pubsub): add default pull lease manager class #13365
  2. impl(pubsub): add pull lease manager interface and mock #13356

This change is Reviewable

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9f856b) 93.06% compared to head (35f5880) 93.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13365   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files        2143     2143           
  Lines      187144   187144           
=======================================
+ Hits       174171   174173    +2     
+ Misses      12973    12971    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,4 @@
// Copyright 2022 Google LLC
// Copyright 2023 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I am not sure we /need/ to update the copyright year here. I think you can, but it may be worthwhile to revisit go/releasing.

@alevenberg alevenberg merged commit 11275ea into googleapis:main Dec 27, 2023
60 checks passed
@alevenberg alevenberg deleted the pull-lease-manager-fix branch December 27, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants