Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generalize name given to TracedAsyncBackoff #13202

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Nov 29, 2023

Motivated by #12959

I want to use a name other than "Async Backoff", so first generalize the function.


This change is Reviewable

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da012e3) 93.00% compared to head (40a3979) 93.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13202   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files        2138     2138           
  Lines      186145   186146    +1     
=======================================
+ Hits       173125   173128    +3     
+ Misses      13020    13018    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review November 29, 2023 11:07
@dbolduc dbolduc requested a review from a team as a code owner November 29, 2023 11:07
@dbolduc dbolduc merged commit c0d3e50 into googleapis:main Nov 29, 2023
59 checks passed
@dbolduc dbolduc deleted the async-traced-backoff-name branch November 29, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants