impl(bigtable): plumb limiter thru AsyncBulkApply #13197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13197 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 2138 2138
Lines 186042 186128 +86
=======================================
+ Hits 173022 173109 +87
+ Misses 13020 13019 -1 ☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #12959
Plumb the
MutateRowsLimiterthrough the layers ofAsyncBulkApply.Note that the implementation is not yet complete, as
MakeMutateRowsLimiter's async sleeper just returns immediately. That will take another 1 or 2 PRs, then we can call the thing done.This change is