impl(bigtable): MutateRowsLimiter can do async #13192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #12959
I considered having the
ThrottlingMutateRowLimiter
hold aCompletionQueue
andOptions const&
, but I think it is nicer to just pass the async sleeper (std::function<future<void>(duration)>
) in.I considered only having an async sleeper, and implementing the following:
I do not want to do this, because in practice the async sleeper will be implemented by a
CompletionQueue
. I do not want to involve aCompletionQueue
in the synchronous code paths.A follow up PR will add a
CompletionQueue
as a parameter to the factory function.Take this opportunity to reorder
MakeMutateRowsLimiter()
to return early from the simpler branch.This change is