feat(aiplatform): generate new services #13150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
approved these changes
Nov 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13150 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 2137 2137
Lines 185804 185804
=======================================
+ Hits 172791 172794 +3
+ Misses 13013 13010 -3 ☔ View full report in Codecov by Sentry. |
devbww
reviewed
Nov 16, 2023
Comment on lines
+388
to
+389
| {R"""(`projects/{project}/locations/{location}'`)""", | ||
| R"""(`projects/{project}/locations/{location}`)"""}, |
There was a problem hiding this comment.
Nit: It doesn't look like the substitution corresponds to the comment for the block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13149
This change is