impl(otel): no spans if no sleeps #13125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13125 +/- ##
==========================================
- Coverage 92.97% 92.97% -0.01%
==========================================
Files 2135 2135
Lines 185654 185665 +11
==========================================
+ Hits 172618 172623 +5
- Misses 13036 13042 +6 ☔ View full report in Codecov by Sentry. |
I agree. Even if there is no sleeping, it may have other side effects (despite this "sleeper" deciding that it won't). |
devbww
approved these changes
Nov 14, 2023
coryan
reviewed
Nov 14, 2023
| @@ -58,8 +58,8 @@ std::unique_ptr<RetryPolicy> TestRetryPolicy() { | |||
| } | |||
|
|
|||
| std::unique_ptr<BackoffPolicy> TestBackoffPolicy() { | |||
| return ExponentialBackoffPolicy(std::chrono::microseconds(1), | |||
There was a problem hiding this comment.
Are these changes related at all?
There was a problem hiding this comment.
Yeah. The backoff policy returns something in milliseconds, which rounds to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #12959
I still like invoking the
sleepereven when the duration is 0.This change is