Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(otel): test with minimum version #13007

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 31, 2023

Fixes #12991

Pin OTel to v1.9.1 in our cmake-oldest-deps build. Communicate this in the packaging doc.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal October 31, 2023 16:40 — with GitHub Actions Inactive
@dbolduc dbolduc marked this pull request as ready for review October 31, 2023 16:59
@dbolduc dbolduc requested a review from a team as a code owner October 31, 2023 16:59
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6581444) 93.60% compared to head (033818e) 93.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13007   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files        2071     2071           
  Lines      181258   181258           
=======================================
  Hits       169671   169671           
  Misses      11587    11587           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 242a883 into googleapis:main Oct 31, 2023
@dbolduc dbolduc deleted the otel-pin-version branch October 31, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify versions of opentelemetry-cpp that we support
2 participants