Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): do not override default sleeper in streaming-read RPCs #12920

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Oct 19, 2023

This change is Reviewable

@devbww devbww temporarily deployed to internal October 19, 2023 04:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2c26eb9) 0.00% compared to head (b012b0d) 93.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main   #12920       +/-   ##
=========================================
+ Coverage      0   93.61%   +93.61%     
=========================================
  Files         0     2067     +2067     
  Lines         0   180119   +180119     
=========================================
+ Hits          0   168627   +168627     
- Misses        0    11492    +11492     
Files Coverage Δ
...v1/internal/golden_kitchen_sink_connection_impl.cc 77.35% <100.00%> (ø)
generator/internal/connection_impl_generator.cc 49.00% <ø> (ø)

... and 2065 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devbww devbww marked this pull request as ready for review October 19, 2023 05:25
@devbww devbww requested a review from a team as a code owner October 19, 2023 05:25
@devbww devbww merged commit ea31442 into googleapis:main Oct 19, 2023
@devbww devbww deleted the streaming-read-sleeper branch October 19, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants