Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(otel): propagate OTelContext #12915

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 18, 2023

Part of the work for #12880

Reimplement CallContext to use our OTelContext instead of using the active span.

Our current implementation produces traces that look sorta correct. But it has problems, as described in the parent issue. This PR breaks the output that "looks sorta correct".

I talked with @alevenberg and we deemed this approach preferable to sending a mega-PR with GAPIC, handwritten library changes. (As long as the issue gets resolved by the next release.)


We remove the "call span active throughout" tests in the async retry loops because it is not something the retry class is doing. That is a property of the async operations, e.g. AsyncUnaryRpcFuture.


Update ABI dumps because we have a false positive on missing templates for types that we don't even own:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
timestamp.h
namespace opentelemetry::v1::common
SystemTimestamp::SystemTimestamp<long, std::ratio<1l, 1000000000l> > [C4] 
( std::chrono::duration<long, std::ratio<1l, 1000000000l> >const& 
time_since_epoch )
_ZN13opentelemetry2v16common15SystemTimestampC4IlSt5ratioILl1ELl1000000000EEEERKNSt6chrono8durationIT_T0_EE



utility.h
namespace absl
forward<variant<monostate>&> ( remove_reference_t& t )
_ZN4absl7forwardIRNS_7variantIJNS_9monostateEblmdN13opentelemetry2v15nostd10shared_ptrINS4_5trace4SpanEEENS6_INS7_11SpanContextEEENS6_INS4_7baggage7BaggageEEEEEEEEOT_RNSt16remove_referenceISH_E4typeE



to the top

Header Files  82 

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal October 18, 2023 04:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (37f726c) 93.61% compared to head (771ca4d) 93.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12915      +/-   ##
==========================================
- Coverage   93.61%   93.61%   -0.01%     
==========================================
  Files        2067     2067              
  Lines      180140   180104      -36     
==========================================
- Hits       168642   168602      -40     
- Misses      11498    11502       +4     
Files Coverage Δ
...e/cloud/bigtable/internal/async_bulk_apply_test.cc 97.51% <100.00%> (ø)
...e/cloud/bigtable/internal/async_row_reader_test.cc 97.47% <100.00%> (ø)
.../cloud/bigtable/internal/async_row_sampler_test.cc 97.68% <100.00%> (ø)
google/cloud/bigtable/row_reader_test.cc 98.21% <100.00%> (ø)
...ogle/cloud/internal/async_connection_ready_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_polling_loop_test.cc 100.00% <100.00%> (ø)
...loud/internal/async_read_write_stream_impl_test.cc 97.94% <100.00%> (ø)
...gle/cloud/internal/async_rest_polling_loop_test.cc 99.04% <100.00%> (ø)
...oogle/cloud/internal/async_rest_retry_loop_test.cc 98.33% <100.00%> (-0.07%) ⬇️
google/cloud/internal/async_retry_loop_test.cc 98.85% <100.00%> (-0.05%) ⬇️
... and 5 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc temporarily deployed to internal October 18, 2023 14:16 — with GitHub Actions Inactive
@dbolduc dbolduc marked this pull request as ready for review October 18, 2023 14:55
@dbolduc dbolduc requested a review from a team as a code owner October 18, 2023 14:55
@dbolduc dbolduc merged commit 6d50ebb into googleapis:main Oct 18, 2023
@dbolduc dbolduc deleted the otel-async-context-propagation branch October 18, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants