Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(otel): detach context from EndSpan(..., future<>) #12902

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 16, 2023

Part of the work for #12880

These EndSpan(..., future<>) are mainly a .then() which might execute in a different thread than the future is returned in. Detach the context from the original thread in the callback thread.

This change is currently a no-op until we start pushing/popping the context and copying the OTelContext into the callback threads.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal October 16, 2023 19:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9523270) 93.61% compared to head (8bb88e7) 93.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12902   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files        2067     2067           
  Lines      180045   180086   +41     
=======================================
+ Hits       168546   168588   +42     
+ Misses      11499    11498    -1     
Files Coverage Δ
google/cloud/internal/grpc_opentelemetry.h 94.11% <100.00%> (+1.26%) ⬆️
google/cloud/internal/grpc_opentelemetry_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/opentelemetry.h 100.00% <100.00%> (ø)
google/cloud/internal/opentelemetry_test.cc 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review October 16, 2023 20:44
@dbolduc dbolduc requested a review from a team as a code owner October 16, 2023 20:44
@dbolduc dbolduc merged commit 3dddc28 into googleapis:main Oct 17, 2023
@dbolduc dbolduc deleted the end-span-future-detach-otel-context branch October 17, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants