-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oauth2): do not require id_token
in creds
#12867
Conversation
id_token
in creds
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the tests too, maybe remove this line:
google-cloud-cpp/google/cloud/internal/oauth2_authorized_user_credentials_test.cc
Line 263 in 953aefe
"id_token": "id-token-value", |
And probably this line too: google-cloud-cpp/google/cloud/internal/oauth2_authorized_user_credentials_test.cc Line 226 in 953aefe
|
36e9af4
to
c08f6e4
Compare
/gcbrun |
I removed those 2 lines. |
Let's go and remove that too. |
Only a limited number of scopes returns this field. For the rest of scopes this field is not populated, which is ok.
c08f6e4
to
8f76295
Compare
/gcbrun |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12867 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2075 2075
Lines 180728 180727 -1
=======================================
+ Hits 169067 169069 +2
+ Misses 11661 11658 -3
☔ View full report in Codecov by Sentry. |
Only a limited number of scopes returns this field. For the rest of scopes this field is not populated, which is ok.
This change is