fix(storage): fix tellg() values #12844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial values for `tellg()` were incorrect `ReadRange()` and `ReadLast()` options.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12844 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 2074 2074
Lines 180452 180548 +96
=======================================
+ Hits 168815 168911 +96
Misses 11637 11637
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Oct 7, 2023
| : source_(std::move(source)), | ||
| source_pos_(pos_in_stream), | ||
| source_pos_(static_cast<std::streamoff>(InitialOffset(request))), |
There was a problem hiding this comment.
Why do we need to static cast to std::streamoff when it looks like InitialOffset() already returns a std::streamoff?
There was a problem hiding this comment.
D'oh! That is what happens when you refactor to a function and forget to clean up the call site.
| if (source_pos_ >= 0) { | ||
| source_pos_ += static_cast<std::streamoff>(read->bytes_received); | ||
| } else if (size_) { | ||
| source_pos_ = *size_ + source_pos_ + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial values for
tellg()were incorrectReadRange()andReadLast()options.This change is