doc(storage): describe default project search #12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12833 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2074 2074
Lines 180352 180352
=======================================
+ Hits 168715 168718 +3
+ Misses 11637 11634 -3
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Oct 6, 2023
google/cloud/storage/client.h
Outdated
| * explicitly by the application, the returned `ListBucketsReader` will | ||
| * return an error status when used. | ||
| * This function will return an error if it cannot determine the "default" | ||
| * project. The function will use: |
There was a problem hiding this comment.
"The function will use:"
Perhaps something more like "The default project is found by looking, in order, for:". Then you don't have to repeat the "If not such value is found:" each time.
google/cloud/storage/client.h
Outdated
| * used. If neither the environment variable is set, nor a value is set | ||
| * explicitly by the application, the server will reject the request and this | ||
| * function will return the error status. | ||
| * |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is